Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC: document OidcError use #3808

Merged
merged 4 commits into from
Oct 18, 2023
Merged

OIDC: document OidcError use #3808

merged 4 commits into from
Oct 18, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Oct 17, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#25665

  • exports OidcError enum from index for use in error messages
  • exports everything else used in react-sdk while I'm there
  • adds documentation about OidcError usage

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Tasks for the team like planning label Oct 17, 2023
@kerryarchibald kerryarchibald requested a review from a team as a code owner October 17, 2023 22:37
@kerryarchibald kerryarchibald mentioned this pull request Oct 17, 2023
Merged
3 tasks
richvdh
richvdh reviewed Oct 18, 2023
View reviewed changes
src/oidc/authorize.ts Outdated Show resolved Hide resolved
src/oidc/register.ts Outdated Show resolved Hide resolved
Kerry and others added 3 commits October 19, 2023 09:56
@richvdh
Update src/oidc/authorize.ts
f2e09cc 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@richvdh
Update src/oidc/register.ts
0797add 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Merge branch 'develop' into kerry/25665/oidc-error
9d739d9
@kerryarchibald kerryarchibald added this pull request to the merge queue Oct 18, 2023
Merged via the queue into develop with commit 4bcea2c Oct 18, 2023
18 checks passed
@kerryarchibald kerryarchibald deleted the kerry/25665/oidc-error branch October 18, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh left review comments

@weeman1337 weeman1337 weeman1337 approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kerryarchibald @richvdh @weeman1337